Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TWE-3 - FE - Home page redesign #325

Merged
merged 3 commits into from
Jan 2, 2025

Conversation

albinazs
Copy link
Collaborator

@albinazs albinazs commented Dec 24, 2024

Link to Ticket for HomePage

Also includes tiny change for the Rich text ticket

Description of Changes Made

Home page redesign:

  • New background with swirls
  • New hero title & introduction style (new grid, fonts, colored links)
  • New 100% employee-owned color (coral theme main colors 50% opacity for both modes - discussed with Ben.E.)
  • Updates for partner logos: max number increased to 12, new image sizes and spacings
  • Updated TBX logo (positioning is a part of https://torchbox.atlassian.net/browse/TWE-17 )
    Header and footer styles are out of the scope of this ticket.

Rich text styles update:

  • Headings font-weight changed to semibold

How to Test

Open the home page itself http://0.0.0.0:8000/ or the pattern library component http://0.0.0.0:8000/pattern-library/pattern/patterns/pages/home/home_page.html

Screenshots

Expand to see more
Screen.Recording.2024-12-24.at.4.10.47.PM.mov

MR Checklist

  • Add a description of your pull request and instructions for the reviewer to verify your work.
  • If your pull request is for a specific ticket, link to it in the description.
  • Stay on point and keep it small so the merge request can be easily reviewed.
  • Tests and linting passes.

Unit tests

  • Added
  • Not required

Documentation

Browser testing

  • I have tested in the following browsers and environments (edit the list as required)
    • Latest version of Chrome on mac
    • Latest version of Firefox on mac
    • Latest version of Safari on mac
    • Safari on last two versions of iOS
    • Chrome on last two versions of Android
  • Not required

Data protection

  • Not relevant
  • This adds new sources of PII and documents it and modifies Birdbath processors accordingly

Light and dark mode

  • I have tested the changes in both light and dark mode
  • The change is not relevant to dark and light mode

Accessibility

  • Automated WCAG 2.1 tests pass
  • HTML validation passes
  • Manual WCAG 2.1 tests completed
  • I have tested in a screen reader
  • I have tested in high-contrast mode
  • Any animations removed for prefers-reduced-motion
  • Not required

Sustainability

  • Images are optimised and lazy-loading used where appropriate
  • SVGs have been optimised
  • Perfomance and transfer of data considered
  • If JavaScript is needed alternatives have been considered
  • Not required

Pattern library

  • The pattern library component for this template displays correctly, and does not break parent templates
  • The styleguide is updated if relevant
  • Changes are not relevant the pattern library

@albinazs albinazs self-assigned this Dec 24, 2024
@chris-lawton
Copy link
Member

This looks great @albinazs - nice work!

I noticed one error in the console regarding the height attr on the swirls svg. I wonder if changing it to 100% from auto would fix it?

Details

Screenshot 2025-01-02 at 09 37 18

@albinazs
Copy link
Collaborator Author

albinazs commented Jan 2, 2025

thank you so much, @chris-lawton - your suggested fix works and is added to the PR

@albinazs albinazs merged commit f2198ff into integration/2024-evolution Jan 2, 2025
4 checks passed
@albinazs albinazs deleted the feature/twe-3-homepage-fe branch January 2, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants